llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-analysis Author: None (jkorous-apple) <details> <summary>Changes</summary> --- Full diff: https://github.com/llvm/llvm-project/pull/80076.diff 2 Files Affected: - (modified) clang/lib/Analysis/UnsafeBufferUsage.cpp (+6-1) - (modified) clang/test/SemaCXX/warn-unsafe-buffer-usage-fixits-pointer-access.cpp (+1) ``````````diff diff --git a/clang/lib/Analysis/UnsafeBufferUsage.cpp b/clang/lib/Analysis/UnsafeBufferUsage.cpp index 7df706beb2266..9046491c9e865 100644 --- a/clang/lib/Analysis/UnsafeBufferUsage.cpp +++ b/clang/lib/Analysis/UnsafeBufferUsage.cpp @@ -1081,11 +1081,16 @@ class UUCAddAssignGadget : public FixableGadget { } static Matcher matcher() { + // clang-format off return stmt(isInUnspecifiedUntypedContext(expr(ignoringImpCasts( binaryOperator(hasOperatorName("+="), - hasLHS(declRefExpr(toSupportedVariable())), + hasLHS( + declRefExpr( + hasPointerType(), + toSupportedVariable())), hasRHS(expr().bind(OffsetTag))) .bind(UUCAddAssignTag))))); + // clang-format on } virtual std::optional<FixItList> getFixits(const Strategy &S) const override; diff --git a/clang/test/SemaCXX/warn-unsafe-buffer-usage-fixits-pointer-access.cpp b/clang/test/SemaCXX/warn-unsafe-buffer-usage-fixits-pointer-access.cpp index 20d9d33195a6b..d1dd26795ba68 100644 --- a/clang/test/SemaCXX/warn-unsafe-buffer-usage-fixits-pointer-access.cpp +++ b/clang/test/SemaCXX/warn-unsafe-buffer-usage-fixits-pointer-access.cpp @@ -85,6 +85,7 @@ void unsafe_method_invocation_single_param() { void safe_method_invocation_single_param() { int* p = new int[10]; + // CHECK-NO: fix-it:"{{.*}}":{[[@LINE-1]]:{{.*}}-[[@LINE-1]]:{{.*}}} foo(p); } `````````` </details> https://github.com/llvm/llvm-project/pull/80076 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
