================
@@ -211,10 +214,12 @@ class IncludeInserter {
// include path of non-verbatim header will not be shortened.
IncludeInserter(StringRef FileName, StringRef Code,
const format::FormatStyle &Style, StringRef BuildDir,
- HeaderSearch *HeaderSearchInfo)
+ HeaderSearch *HeaderSearchInfo, HeaderFilter QuotedHeaders,
----------------
HighCommander4 wrote:
We're taking `ArrayRef`s here, and passing it `vectors` that live in `Config`.
How confident are we that this is ok from a lifetime point of view, i.e. the
`Config` object will outlive the `IncludeInserter` object? How confident are we
that this will remain the case across future refactorings?
Would it be better to copy the vector instead? Each element is a function which
stores a shared_ptr to a vector of regexes, so we wouldn't be copying the
regexes the themselves.
https://github.com/llvm/llvm-project/pull/67749
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
