HighCommander4 wrote:

> Can we write a unit test for this?

I'm open to trying but there are a few open questions in my mind:

 * Is it fine if the failure mode of a testcase is triggering an OOM?
 * Triggering the problematic codepath requires a combination of a large file 
(thousands of lines) and many preprocessor branches on those lines. Should I be 
looking to copy one of the affected single-header libraries (e.g. miniaudio.h) 
into the test suite for this purpose? Or should I try to synthesize a file with 
dummy content that meets these criteria?

https://github.com/llvm/llvm-project/pull/78925
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to