https://github.com/NagyDonat approved this pull request.
Looks reasonable. My only concern is that several recent changes introduced similar, but separate `evalXXX` methods that are used for modeling just one or two standard functions. I have a vague suspicion that these could be "standardized" (e.g. by moving their common parts into helper functions) to reduce the length and complexity of the code. https://github.com/llvm/llvm-project/pull/78693 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
