================ @@ -2178,7 +2178,7 @@ createAndSetPrivatizedLoopVar(Fortran::lower::AbstractConverter &converter, template <typename Op> static void createBodyOfOp( Op &op, Fortran::lower::AbstractConverter &converter, mlir::Location &loc, - Fortran::lower::pft::Evaluation &eval, + Fortran::lower::pft::Evaluation &eval, bool genNested, ---------------- skatrak wrote:
I guess this is just a matter of taste, so feel free to leave it as is. The reason why I suggested the change is that there are two boolean flags passed in: `genNested` and `outerCombined`. The first one indicates _what_ it will do and the second indicates _when_ the caller should set it to true, so I thought it would be good if both conveyed information in the same way. https://github.com/llvm/llvm-project/pull/77760 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits