[lldb] [flang] [libcxx] [lld] [clang] [compiler-rt] [libcxxabi] [libunwind] [libc] [llvm] [clang-tools-extra] Fix a bug in Smith's algorithm used in complex div/mul. (PR #78330)

[Andy Kaylor via cfe-commits]

================
@@ -2780,24 +2781,24 @@ static void RenderFloatingPointOptions(const ToolChain 
&TC, const Driver &D,
     case options::OPT_fcx_limited_range: {
       EmitComplexRangeDiag(D, Range, 
LangOptions::ComplexRangeKind::CX_Limited);
       Range = LangOptions::ComplexRangeKind::CX_Limited;
-      std::string ComplexRangeStr = RenderComplexRangeOption("limited");
-      if (!ComplexRangeStr.empty())
-        CmdArgs.push_back(Args.MakeArgString(ComplexRangeStr));
+      ComplexRangeStr = RenderComplexRangeOption("limited");
----------------
andykaylor wrote:

I think it would be better to move the rendering of this option to the bottom 
of this function (around line 3124) to avoid inserting multiple, conflicting 
options if more than one -f[no-]cx-* option is used.

https://github.com/llvm/llvm-project/pull/78330
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits