https://github.com/tblah approved this pull request.

Makes sense. For reference, here I was trying to reproduce the logic from 
https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/Clang.cpp#L5364
 and 
https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/Darwin.cpp#L752.

In light of your fix, it does look like the clang logic would have rendered the 
argument on darwin (as well as possibly adding `-framework Accelerate`). So 
this LGTM.

Thanks for catching my mistake!

https://github.com/llvm/llvm-project/pull/77605
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to