mordante wrote: > > I did a full review. There are a number of comments, once these are > > addressed the patch is ready. > > Thank you for the detailed review and patience! > > I believe the failing tests are unrelated to this patch: > > > Failed Tests (2): > > llvm-libc++-shared-clangcl.cfg.in :: > > libcxx/utilities/expected/expected.expected/transform_error.mandates.verify.cpp > > llvm-libc++-shared-clangcl.cfg.in :: > > libcxx/utilities/expected/expected.void/transform_error.mandates.verify.cpp
The breakage is indeed unrelated. I've reverted the patch that introduced it. https://github.com/llvm/llvm-project/pull/76632 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
