pogo59 wrote: >From a UI perspective, "add a visibility attribute" doesn't seem all that >descriptive. What visibility does it add? Therefore, I suggest >`-fvisibility-global-new-delete[=<visibility>]` so the user can ask for what >they want, and `-fvisibility-global-new-delete-hidden` equals >`-fvisibility-global-new-delete=hidden`. The help text can indicate that the >default is `default`.
I'm unclear what the `-fno` variant actually turns into. There's always a visibility, ultimately, right? So wouldn't that be equivalent to the `keep` option in #74629 ? Which suggests not having the `-fno` variant here, and allowing `=keep` instead. (If the universe would implode given a visibility other than `default` or `hidden` for global new/delete, then constrain the argument to the option to be only `default/hidden/keep`.) I hope this makes sense... https://github.com/llvm/llvm-project/pull/75364 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
