minglotus-6 wrote:

Using the same added ICP test,  profile matching on local-linkage 
`_ZL7callee0v` using `clang++ -v -fuse-ld=lld -O2 
-fprofile-use=thinlto_icall_prom.profdata <file-list>` , as 
[this](https://gist.github.com/minglotus-6/11817ba645c6b12cd7116f41bfb1185e) 
pgo-instr-use output shows.

However, when trying to follow the counter matching [code 
path](https://github.com/llvm/llvm-project/blob/df7545e4be5cb65ef3ddd278119c0b8b2f37b0ec/llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp#L1337),
 I came across another 
place(https://github.com/llvm/llvm-project/blob/df7545e4be5cb65ef3ddd278119c0b8b2f37b0ec/llvm/lib/ProfileData/InstrProfReader.cpp#L1019)
 that might have something to do with colon/semicolon delimiter inside itanium 
remapper 
(https://github.com/llvm/llvm-project/blob/df7545e4be5cb65ef3ddd278119c0b8b2f37b0ec/llvm/lib/ProfileData/InstrProfReader.cpp#L1055).
 I'm wondering if this needs an update (with updated regression test)? 
@david-xl @xur-llvm who might have more context.


https://github.com/llvm/llvm-project/pull/74008
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to