=?utf-8?q?Donát?= Nagy <donat.n...@ericsson.com> Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/67...@github.com>
DonatNagyE wrote: > > Before merging this PR, the diagnostics of the EnumCast checker should be > > updated to mention the name of the `enum` type in question. @gamesh411 > > could you create a PR that implements this improvement (as we discussed)? > > Yes, it should call out the enum, call out the value, and then _track_ the > value (with `trackExpressionValue()`) in order to explain where it's coming > from and why we think it's out of range. These suggestions were mostly implemented in https://github.com/llvm/llvm-project/pull/68191/ , I created PR https://github.com/llvm/llvm-project/pull/74503 to implement the last missing part ("call out the value"). https://github.com/llvm/llvm-project/pull/67157 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
