================ @@ -322,6 +322,90 @@ static Attr *handleUnlikely(Sema &S, Stmt *St, const ParsedAttr &A, return ::new (S.Context) UnlikelyAttr(S.Context, A); } +CodeAlignAttr *Sema::BuildCodeAlignAttr(const AttributeCommonInfo &CI, + Expr *E) { + if (!E->isValueDependent()) { + llvm::APSInt ArgVal; + ExprResult Res = VerifyIntegerConstantExpression(E, &ArgVal); + if (Res.isInvalid()) + return nullptr; + E = Res.get(); + + // This attribute requires an integer argument which is a constant power of + // two between 1 and 4096 inclusive. + // Check if an expression resulting in a negative/positive cases that take + // more than 64 bits. + // Print the actual alignment value passing to the attribute if it is less + // than 64 bits otherwise print the expression. + if (ArgVal < CodeAlignAttr::MinimumAlignment || + (ArgVal < CodeAlignAttr::MaximumAlignment && !ArgVal.isPowerOf2())) { + if (!ArgVal.trySExtValue()) { + Diag(CI.getLoc(), diag::err_attribute_power_of_two_in_range) + << CI << CodeAlignAttr::MinimumAlignment + << CodeAlignAttr::MaximumAlignment << E; + return nullptr; + } else { + Diag(CI.getLoc(), diag::err_attribute_power_of_two_in_range) + << CI << CodeAlignAttr::MinimumAlignment + << CodeAlignAttr::MaximumAlignment << ArgVal.getSExtValue(); + return nullptr; + } + } + + if (ArgVal > CodeAlignAttr::MaximumAlignment) { ---------------- erichkeane wrote:
You can also make this the same as the Minimum and power of 2 above, since the contents are the same (that is, add `|| ArgVal > ...Maximum..` above. https://github.com/llvm/llvm-project/pull/70762 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits