Michael137 wrote: > > We're seeing crashes after this. Here is a reproducer: > > https://bugs.chromium.org/p/chromium/issues/detail?id=1502489#c1 > > Please consider reverting if it can't be fixed quickly (I had a look, but > > it seems there are some dependent changes on top). > > Thanks for reporting, will check and revert if not obvious what's wrong
Just based on the backtrace the only cause I see would be if we put a nullptr into `StaticDataMemberDefinitionsToEmit`. We unconditionally dereference it. In which case the fix is pretty straightforward. Building a local debug build to confirm this theory. https://github.com/llvm/llvm-project/pull/71780 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
