llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: None (ls-Mou) <details> <summary>Changes</summary> -rdynamic option should not use with -static, as shown in the following code https://github.com/llvm/llvm-project/blob/f86770aa073ac9c17d9ccb6409254e879dca2de6/clang/lib/Driver/ToolChains/Gnu.cpp#L460-L472 So I think the code in line 420-421 should be deleted. https://github.com/llvm/llvm-project/blob/f86770aa073ac9c17d9ccb6409254e879dca2de6/clang/lib/Driver/ToolChains/Gnu.cpp#L420-L421 --- Full diff: https://github.com/llvm/llvm-project/pull/72089.diff 1 Files Affected: - (modified) clang/lib/Driver/ToolChains/Gnu.cpp (-3) ``````````diff diff --git a/clang/lib/Driver/ToolChains/Gnu.cpp b/clang/lib/Driver/ToolChains/Gnu.cpp index 19dff4ec4d45e08..6c0041279de5a27 100644 --- a/clang/lib/Driver/ToolChains/Gnu.cpp +++ b/clang/lib/Driver/ToolChains/Gnu.cpp @@ -417,9 +417,6 @@ void tools::gnutools::Linker::ConstructJob(Compilation &C, const JobAction &JA, CmdArgs.push_back("text"); } - if (Args.hasArg(options::OPT_rdynamic)) - CmdArgs.push_back("-export-dynamic"); - if (Args.hasArg(options::OPT_s)) CmdArgs.push_back("-s"); `````````` </details> https://github.com/llvm/llvm-project/pull/72089 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits