zequanwu added inline comments.
================ Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:607 + // compiler has broken. + assert((!StartLoc || StartLoc->isValid()) && "Start location is not valid"); + assert((!EndLoc || EndLoc->isValid()) && "End location is not valid"); ---------------- MaskRay wrote: > Is this workaround still needed after > b0e61de7075942ef5ac8af9ca1ec918317f62152 (with a test > `clang/test/Coverage/unresolved-ctor-expr.cpp`)? I think this workaround can be removed, verified it no longer crashes if reverting this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147073/new/ https://reviews.llvm.org/D147073 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
