[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor (NFC) (PR #70427)

[Kohei Asano via cfe-commits]

https://github.com/khei4 updated https://github.com/llvm/llvm-project/pull/70427

>From f9f61fd520727d1e03269af4b5c1e40119d7524e Mon Sep 17 00:00:00 2001
From: khei4 <kk.asano.l...@gmail.com>
Date: Fri, 27 Oct 2023 17:46:34 +0900
Subject: [PATCH] use: create instead of protected Constructor

handle: expected

fix: later example also
---
 clang/docs/LibTooling.rst | 22 ++++++++++++++++++----
 1 file changed, 18 insertions(+), 4 deletions(-)

diff --git a/clang/docs/LibTooling.rst b/clang/docs/LibTooling.rst
index df50dcebf9b83c7..2f60b8cab70c5a3 100644
--- a/clang/docs/LibTooling.rst
+++ b/clang/docs/LibTooling.rst
@@ -69,9 +69,16 @@ and automatic location of the compilation database using 
source files paths.
   static llvm::cl::OptionCategory MyToolCategory("my-tool options");
 
   int main(int argc, const char **argv) {
-    // CommonOptionsParser constructor will parse arguments and create a
-    // CompilationDatabase.  In case of error it will terminate the program.
-    CommonOptionsParser OptionsParser(argc, argv, MyToolCategory);
+    // CommonOptionsParser::create will parse arguments and create a
+    // CompilationDatabase. In case of error it will terminate the program.
+    llvm::Expected<CommonOptionsParser> Expected =
+        CommonOptionsParser::create(argc, argv, MyToolCategory);
+    if (!Expected)
+    {
+      llvm::errs() << Expected.takeError();
+      return 1;
+    }
+    CommonOptionsParser &OptionsParser = Expected.get();
 
     // Use OptionsParser.getCompilations() and 
OptionsParser.getSourcePathList()
     // to retrieve CompilationDatabase and the list of input file paths.
@@ -133,7 +140,14 @@ version of this example tool is also checked into the 
clang tree at
   static cl::extrahelp MoreHelp("\nMore help text...\n");
 
   int main(int argc, const char **argv) {
-    CommonOptionsParser OptionsParser(argc, argv, MyToolCategory);
+    Expected<CommonOptionsParser> Expected =
+        CommonOptionsParser::create(argc, argv, MyToolCategory);
+    if (!Expected)
+    {
+      errs() << Expected.takeError();
+      return 1;
+    }
+    CommonOptionsParser &OptionsParser = Expected.get();
     ClangTool Tool(OptionsParser.getCompilations(),
                    OptionsParser.getSourcePathList());
     return Tool.run(newFrontendActionFactory<clang::SyntaxOnlyAction>().get());

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits