rsmith added inline comments.
> PrintPreprocessedOutput.cpp:328
> + case '"': // paths are enclosed in quotes; escape them
> + case '*': // don't allow a "*/" sequence to accidentally open the
> comment
> + case '\\': // escape the escape character itself.
Putting a \ before a * won't stop it being recognised as part of a */.
> PrintPreprocessedOutput.cpp:329
> + case '*': // don't allow a "*/" sequence to accidentally open the
> comment
> + case '\\': // escape the escape character itself.
> + str[len++] = '\\';
Is this really necessary? It'll be very ugly on Windows.
> PrintPreprocessedOutput.cpp:396
> + StringRef InclusionKeyword("include");
> + tryGetTokenText(&InclusionKeyword, IncludeTok);
> +
Please do this in the preceding case too.
https://reviews.llvm.org/D25153
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
