Author: Congcong Cai Date: 2023-10-26T09:24:17+08:00 New Revision: 04ca1b6bd938646874b6518067f03515d88c3b5b
URL: https://github.com/llvm/llvm-project/commit/04ca1b6bd938646874b6518067f03515d88c3b5b DIFF: https://github.com/llvm/llvm-project/commit/04ca1b6bd938646874b6518067f03515d88c3b5b.diff LOG: [clang-tidy]fix misc-unused-using-decls false positive false for using in elaborated type (#70230) `ElaboratedType` including tag keywords and any nested-name-specifiers. We should ignore nested-name-specifiers case but consider tag keywords case for `misc-unused-using-decls` check Fixes: #69714 Added: Modified: clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp clang-tools-extra/docs/ReleaseNotes.rst clang-tools-extra/test/clang-tidy/checkers/misc/unused-using-decls.cpp Removed: ################################################################################ diff --git a/clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp b/clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp index 14b6aca6f3b8fac..051375263e53c3f 100644 --- a/clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp +++ b/clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp @@ -8,6 +8,7 @@ #include "UnusedUsingDeclsCheck.h" #include "clang/AST/ASTContext.h" +#include "clang/AST/Decl.h" #include "clang/ASTMatchers/ASTMatchFinder.h" #include "clang/Lex/Lexer.h" @@ -71,6 +72,10 @@ void UnusedUsingDeclsCheck::registerMatchers(MatchFinder *Finder) { templateArgument().bind("used")))), this); Finder->addMatcher(userDefinedLiteral().bind("used"), this); + Finder->addMatcher( + loc(elaboratedType(unless(hasQualifier(nestedNameSpecifier())), + hasUnqualifiedDesugaredType(type().bind("usedType")))), + this); // Cases where we can identify the UsingShadowDecl directly, rather than // just its target. // FIXME: cover more cases in this way, as the AST supports it. @@ -145,6 +150,12 @@ void UnusedUsingDeclsCheck::check(const MatchFinder::MatchResult &Result) { return; } + if (const auto *T = Result.Nodes.getNodeAs<Type>("usedType")) { + if (const auto *ND = T->getAsTagDecl()) + RemoveNamedDecl(ND); + return; + } + if (const auto *UsedShadow = Result.Nodes.getNodeAs<UsingShadowDecl>("usedShadow")) { removeFromFoundDecls(UsedShadow->getTargetDecl()); diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst index fb2226f15045996..6d1992e12130d65 100644 --- a/clang-tools-extra/docs/ReleaseNotes.rst +++ b/clang-tools-extra/docs/ReleaseNotes.rst @@ -291,6 +291,10 @@ Changes in existing checks <clang-tidy/checks/misc/redundant-expression>` check to ignore false-positives in unevaluated context (e.g., ``decltype``). +- Improved :doc:`misc-unused-using-decls + <clang-tidy/checks/misc/unused-using-decls>` check to avoid false positive when + using in elaborated type. + - Improved :doc:`modernize-avoid-bind <clang-tidy/checks/modernize/avoid-bind>` check to not emit a ``return`` for fixes when the function returns ``void``. diff --git a/clang-tools-extra/test/clang-tidy/checkers/misc/unused-using-decls.cpp b/clang-tools-extra/test/clang-tidy/checkers/misc/unused-using-decls.cpp index 7d02aa4d2e2bf90..12fc18f340f2130 100644 --- a/clang-tools-extra/test/clang-tidy/checkers/misc/unused-using-decls.cpp +++ b/clang-tools-extra/test/clang-tidy/checkers/misc/unused-using-decls.cpp @@ -213,3 +213,12 @@ template <typename T, template <typename> class U> class Bar {}; // We used to report Q unsued, because we only checked the first template // argument. Bar<int, Q> *bar; + +namespace gh69714 { +struct StructGH69714_1 {}; +struct StructGH69714_2 {}; +} // namespace gh69714 +using gh69714::StructGH69714_1; +using gh69714::StructGH69714_2; +struct StructGH69714_1 a; +struct StructGH69714_2 *b; _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
