================ @@ -0,0 +1,46 @@ +//===--- CastingThroughVoidCheck.cpp - clang-tidy -------------------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#include "CastingThroughVoidCheck.h" +#include "clang/AST/ASTContext.h" +#include "clang/AST/Expr.h" +#include "clang/AST/Type.h" +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include "clang/ASTMatchers/ASTMatchers.h" +#include "llvm/ADT/StringSet.h" + +using namespace clang::ast_matchers; + +namespace clang::tidy::bugprone { + +void CastingThroughVoidCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( + explicitCastExpr( + hasDestinationType(qualType(pointsTo(qualType(unless(voidType())))) + .bind("target_type")), + hasSourceExpression( + explicitCastExpr(hasSourceExpression(expr( + hasType(qualType().bind("source_type")))), + hasDestinationType(pointsTo(voidType()))))) + .bind("cast"), + this); +} + +void CastingThroughVoidCheck::check(const MatchFinder::MatchResult &Result) { + ASTContext *Context = Result.Context; + const auto *CE = Result.Nodes.getNodeAs<ExplicitCastExpr>("cast"); + const auto *TT = Result.Nodes.getNodeAs<QualType>("target_type"); + const auto *ST = Result.Nodes.getNodeAs<QualType>("source_type"); + if (Context->hasSameType(*TT, *ST)) + return; + diag(CE->getSourceRange().getBegin(), "do not cast %0 to %1 through void *", + DiagnosticIDs::Level::Warning) + << ST->getAsString() << TT->getAsString(); ---------------- PiotrZSL wrote:
``` << ST or << *ST will work, not need for getAsString ``` https://github.com/llvm/llvm-project/pull/69465 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
