hfinkel added a comment. In https://reviews.llvm.org/D18639#545697, @EricWF wrote:
> LGTM. > > In https://reviews.llvm.org/D18639#514991, @hfinkel wrote: > > > In https://reviews.llvm.org/D18639#491232, @mclow.lists wrote: > > > > > And is there any reason why `__libcpp_isinf` can't just return `false` > > > for non-fp types? > > > > > > For custom numeric types that have an isinf, etc. found by ADL, they should > > continue to work. > > > Do we already support custom numeric types? If so could you add a test for > this under `test/libcxx`? Just a simple test case that instantiates the > functions and shows it compiles. As it turns out, the answer is: mostly. We should discuss this more: PR30589. https://reviews.llvm.org/D18639 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
