bjope wrote:

> So the change itself looks right. The comment at the top of the test belongs 
> in the commit message/github discussion, not in the test itself.
> 
> Also, needs a release note.

Thanks. I pushed an update. It fixes the test case to just explain the purpose 
of the tests. And I added info to the ReleaseNotes.

Note: I've never edited release notes for clang in the past, so please let me 
know if that should go somewhere else or if I missed something about what it 
should look like, etc. 

https://github.com/llvm/llvm-project/pull/68590
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to