I went back to a50e63b38b931d945f97eac882278068221eca17. There, my release+asserts build failed, but my release-without-asserts build was OK. I used clang-14.0.6 as the host compiler for both of these builds.
I reapplied a50e63b38b931d945f97eac882278068221eca17 at the tip (5e159972917fb7d02347f98d7431f1d02bee33b6 to be exact). Now both release+asserts and release-without-asserts builds are OK. I don't know what happened in between. In any event, I'm sorry for the noise. Would you mind re-applying the patch? (Or maybe I should?) Thanks, Kazu Hirata On Thu, Oct 5, 2023 at 3:33 PM Kazu Hirata <k...@google.com> wrote: > Hmm. No, I was using a clean tree. I tried > a50e63b38b931d945f97eac882278068221eca17 and the commit immediately before, > and the build problem showed up at a50e63b38b931d945f97eac882278068221eca17. > > Let me re-apply the patch locally and try both gcc and clang (as the host > compilers). > > Kazu Hirata > > > On Thu, Oct 5, 2023 at 1:26 PM Aaron Ballman <aa...@aaronballman.com> > wrote: > >> On Thu, Oct 5, 2023 at 4:19 PM Aaron Ballman <aa...@aaronballman.com> >> wrote: >> > >> > On Thu, Oct 5, 2023 at 4:18 PM Aaron Ballman <aa...@aaronballman.com> >> wrote: >> > > >> > > On Thu, Oct 5, 2023 at 4:08 PM Kazu Hirata via cfe-commits >> > > <cfe-commits@lists.llvm.org> wrote: >> > > > >> > > > >> > > > Author: Kazu Hirata >> > > > Date: 2023-10-05T13:08:24-07:00 >> > > > New Revision: a6acf3fd49a20c570a390af2a3c84e10b9545b68 >> > > > >> > > > URL: >> https://github.com/llvm/llvm-project/commit/a6acf3fd49a20c570a390af2a3c84e10b9545b68 >> > > > DIFF: >> https://github.com/llvm/llvm-project/commit/a6acf3fd49a20c570a390af2a3c84e10b9545b68.diff >> > > > >> > > > LOG: Revert "Fixes and closes #53952. Setting the >> ASTHasCompilerErrors member variable correctly based on the PP diagnostics. >> (#68127)" >> > > > >> > > > This reverts commit a50e63b38b931d945f97eac882278068221eca17. >> > > > >> > > > With clang-14.0.6 as the host compiler, I'm getting: >> > > > >> > > > ld.lld: error: undefined symbol: >> clang::ASTWriter::WriteAST(clang::Sema&, llvm::StringRef, clang::Module*, >> llvm::StringRef, bool, bool) >> > > > >>> referenced by ASTUnit.cpp >> > > > >>> >> ASTUnit.cpp.o:(clang::ASTUnit::serialize(llvm::raw_ostream&)) in archive >> lib/libclangFrontend.a >> > > >> > > That's expected; we removed a parameter that appeared to be unused and >> > > was causing problems. Is lld using the parameter that was removed? If >> > > so, what was the intent of overriding the diagnostics engine? >> > >> > Oh. I see, it wasn't lld using it, it comes from a missed usage in >> > ASTUnit.cpp that should have been updated. >> >> Nope, I'm back to being baffled. That code was updated in the PR and >> no bots went red with the change. We may need more details in order to >> address this; alternatively, did you have local changes to ASTUnit.cpp >> so that the file didn't get updated for you? >> >> ~Aaron >> >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
