klimek added inline comments.
================
Comment at: unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:2119
@@ +2118,3 @@
+ "template <typename U>\n"
+ "void Function(Namespace::Template<U> param) {\n"
+ " param.Method();\n"
----------------
Given your use case: why do we need hasDeclaration here at all?
I'd have expected this working with just matching on the nested name specifier
of the type instead of saying hasDeclaration on the template type.
Btw, if you add a type alias for a class not in the namespace into the
namespace (typedef / using), do you wan that to rename or not? :)
I'd personally probably have expected (2), but I'm never sure in these cases
without playing around with more test cases...
https://reviews.llvm.org/D24361
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
