kbarton added a comment.

Aside from one minor comment, this LGTM.


================
Comment at: lib/Basic/Targets.cpp:1364
@@ -1358,3 +1363,3 @@
 // Handle explicit options being passed to the compiler here: if we've
 // explicitly turned off vsx and turned on power8-vector or direct-move then
 // go ahead and error since the customer has expressed a somewhat incompatible
----------------
Please  update this comment to also include float128 and power9-vector.



Repository:
  rL LLVM

https://reviews.llvm.org/D24397



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to