thakis added inline comments.
================ Comment at: clang/test/OpenMP/amdgpu_throw_trap.cpp:4 +// RUN: %clang_cc1 -fopenmp -triple amdgcn-amd-amdhsa -fopenmp-is-target-device %s -emit-llvm -S -Wno-openmp-target-exception -o - | FileCheck -check-prefix=DEVICE %s +// RUN: %clang_cc1 -fopenmp -triple x86_64-pc-linux-gnu -fopenmp-is-target-device -fcxx-exceptions %s -emit-llvm -S -Wno-openmp-target-exception -o - | FileCheck -check-prefix=HOST %s +// DEVICE: s_trap ---------------- aeubanks wrote: > thakis wrote: > > This test fails if X86 isn't in `LLVM_TARGETS_TO_BUILD` and the host system > > is some non-x86 system (e.g. arm64). > > > > (This is the only test in check-clang that fails then.) > > > > Should this test grow a `REQUIRES: x86-registered-target`? Should it use > > `%itanium_abi_triple` instead of `x86_64-pc-linux-gnu`? (It seems to pass > > when replacing `x86_64-pc-linux-gnu` with `%itanium_abi_triple` on my arm > > mac.) > added x86-registered-target in 238a1ef44f4f2361205e538b3cb7ebc5ec70894d Is that better than `%itanium_abi_triple`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153924/new/ https://reviews.llvm.org/D153924 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
