https://github.com/SuperSodaSea created https://github.com/llvm/llvm-project/pull/65906:
(Moved from <https://reviews.llvm.org/D154646>.) >From feb31f4590ce6d80cea170efe179c253c29c5138 Mon Sep 17 00:00:00 2001 From: SuperSodaSea <bobby...@126.com> Date: Fri, 7 Jul 2023 03:38:53 +0800 Subject: [PATCH] Fix some typos in comments: evalute -> evaluate (NFC) --- clang/include/clang/AST/Expr.h | 2 +- clang/lib/Serialization/ASTWriter.cpp | 2 +- .../unittests/Analysis/FlowSensitive/TransferTest.cpp | 2 +- flang/include/flang/Lower/Support/Utils.h | 2 +- flang/lib/Evaluate/shape.cpp | 2 +- .../include/mlir/Dialect/Linalg/IR/LinalgInterfaces.td | 10 +++++----- openmp/libomptarget/test/lit.cfg | 2 +- 7 files changed, 11 insertions(+), 11 deletions(-) diff --git a/clang/include/clang/AST/Expr.h b/clang/include/clang/AST/Expr.h index c9315de8024e2f1..fe20a84216d1f11 100644 --- a/clang/include/clang/AST/Expr.h +++ b/clang/include/clang/AST/Expr.h @@ -566,7 +566,7 @@ class Expr : public ValueStmt { SmallVectorImpl< PartialDiagnosticAt> &Diags); - /// isPotentialConstantExprUnevaluted - Return true if this expression might + /// isPotentialConstantExprUnevaluated - Return true if this expression might /// be usable in a constant expression in C++11 in an unevaluated context, if /// it were in function FD marked constexpr. Return false if the function can /// never produce a constant expression, along with diagnostics describing diff --git a/clang/lib/Serialization/ASTWriter.cpp b/clang/lib/Serialization/ASTWriter.cpp index 5ba07271cd81867..65bee806d2c5571 100644 --- a/clang/lib/Serialization/ASTWriter.cpp +++ b/clang/lib/Serialization/ASTWriter.cpp @@ -6081,7 +6081,7 @@ void ASTRecordWriter::AddVarDeclInit(const VarDecl *VD) { Val |= (ES->HasConstantInitialization ? 2 : 0); Val |= (ES->HasConstantDestruction ? 4 : 0); APValue *Evaluated = VD->getEvaluatedValue(); - // If the evaluted result is constant, emit it. + // If the evaluated result is constant, emit it. if (Evaluated && (Evaluated->isInt() || Evaluated->isFloat())) Val |= 8; } diff --git a/clang/unittests/Analysis/FlowSensitive/TransferTest.cpp b/clang/unittests/Analysis/FlowSensitive/TransferTest.cpp index ec07555d7f33b3b..cced3925c4721c5 100644 --- a/clang/unittests/Analysis/FlowSensitive/TransferTest.cpp +++ b/clang/unittests/Analysis/FlowSensitive/TransferTest.cpp @@ -5855,7 +5855,7 @@ TEST(TransferTest, AnonymousStructWithReferenceField) { TEST(TransferTest, EvaluateBlockWithUnreachablePreds) { // This is a crash repro. - // `false` block may not have been processed when we try to evalute the `||` + // `false` block may not have been processed when we try to evaluate the `||` // after visiting `true`, because it is not necessary (and therefore the edge // is marked unreachable). Trying to get the analysis state via // `getEnvironment` for the subexpression still should not crash. diff --git a/flang/include/flang/Lower/Support/Utils.h b/flang/include/flang/Lower/Support/Utils.h index 9ab00dad51d39a5..64641ab4b6ca13e 100644 --- a/flang/include/flang/Lower/Support/Utils.h +++ b/flang/include/flang/Lower/Support/Utils.h @@ -89,7 +89,7 @@ namespace Fortran::lower { // Fortran::evaluate::Expr are functional values organized like an AST. A // Fortran::evaluate::Expr is meant to be moved and cloned. Using the front end // tools can often cause copies and extra wrapper classes to be added to any -// Fortran::evalute::Expr. These values should not be assumed or relied upon to +// Fortran::evaluate::Expr. These values should not be assumed or relied upon to // have an *object* identity. They are deeply recursive, irregular structures // built from a large number of classes which do not use inheritance and // necessitate a large volume of boilerplate code as a result. diff --git a/flang/lib/Evaluate/shape.cpp b/flang/lib/Evaluate/shape.cpp index ada26ac46af8363..8f4923ff96a94b0 100644 --- a/flang/lib/Evaluate/shape.cpp +++ b/flang/lib/Evaluate/shape.cpp @@ -1086,7 +1086,7 @@ void GetShapeHelper::AccumulateExtent( result = std::move(result) + std::move(n); if (context_) { // Fold during expression creation to avoid creating an expression so - // large we can't evalute it without overflowing the stack. + // large we can't evaluate it without overflowing the stack. result = Fold(*context_, std::move(result)); } } diff --git a/mlir/include/mlir/Dialect/Linalg/IR/LinalgInterfaces.td b/mlir/include/mlir/Dialect/Linalg/IR/LinalgInterfaces.td index 4567b3f1902d728..c45ec11a46cb7cc 100644 --- a/mlir/include/mlir/Dialect/Linalg/IR/LinalgInterfaces.td +++ b/mlir/include/mlir/Dialect/Linalg/IR/LinalgInterfaces.td @@ -324,7 +324,7 @@ def LinalgStructuredInterface : OpInterface<"LinalgOp"> { // MLIR currently does not support dependent interfaces or interface // inheritance. By construction all ops with StructuredOpInterface must // implement DestinationStyleOpInterface. - // TODO: reevalute the need for a cast when a better mechanism exists. + // TODO: reevaluate the need for a cast when a better mechanism exists. return getBlock()->getArguments().take_front( cast<DestinationStyleOpInterface>(*this->getOperation()) .getNumDpsInputs()); @@ -342,7 +342,7 @@ def LinalgStructuredInterface : OpInterface<"LinalgOp"> { // MLIR currently does not support dependent interfaces or interface // inheritance. By construction all ops with StructuredOpInterface must // implement DestinationStyleOpInterface. - // TODO: reevalute the need for a cast when a better mechanism exists. + // TODO: reevaluate the need for a cast when a better mechanism exists. return getBlock()->getArguments().take_back( cast<DestinationStyleOpInterface>(*this->getOperation()) .getNumDpsInits()); @@ -421,7 +421,7 @@ def LinalgStructuredInterface : OpInterface<"LinalgOp"> { // MLIR currently does not support dependent interfaces or interface // inheritance. By construction all ops with StructuredOpInterface must // implement DestinationStyleOpInterface. - // TODO: reevalute the need for a cast when a better mechanism exists. + // TODO: reevaluate the need for a cast when a better mechanism exists. return *(indexingMaps.begin() + cast<DestinationStyleOpInterface>(*this->getOperation()) .getNumDpsInputs() + @@ -442,7 +442,7 @@ def LinalgStructuredInterface : OpInterface<"LinalgOp"> { // MLIR currently does not support dependent interfaces or interface // inheritance. By construction all ops with StructuredOpInterface must // implement DestinationStyleOpInterface. - // TODO: reevalute the need for a cast when a better mechanism exists. + // TODO: reevaluate the need for a cast when a better mechanism exists. int64_t resultIndex = opOperand->getOperandNumber() - cast<DestinationStyleOpInterface>(*this->getOperation()) @@ -807,7 +807,7 @@ def LinalgStructuredInterface : OpInterface<"LinalgOp"> { // MLIR currently does not support dependent interfaces or interface // inheritance. By construction all ops with StructuredOpInterface must // implement DestinationStyleOpInterface. - // TODO: reevalute the need for a cast when a better mechanism exists. + // TODO: reevaluate the need for a cast when a better mechanism exists. //========================================================================// int64_t getNumDpsInputs() { diff --git a/openmp/libomptarget/test/lit.cfg b/openmp/libomptarget/test/lit.cfg index f54edf91574671e..a53d4e32436de12 100644 --- a/openmp/libomptarget/test/lit.cfg +++ b/openmp/libomptarget/test/lit.cfg @@ -45,7 +45,7 @@ def append_dynamic_library_path(name, value, sep): else: config.environment[name] = value -# Evalute the environment variable which is a string boolean value. +# Evaluate the environment variable which is a string boolean value. def evaluate_bool_env(env): env = env.lower() possible_true_values = ["on", "true", "1"] _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits