================
@@ -134,7 +134,48 @@ class Template {
   bool empty() const { return Parameters.empty() && Constraints.empty(); }
 };
 
-/// DocComment is a vector of RawComment::CommentLine.
+/// Slightly cut down version of PresumedLoc to suit the needs of
+/// ExtractAPI.
+class RecordLocation {
+  unsigned Line, Col;
+  std::string Filename;
----------------
Arsenic-ATG wrote:

Due to some reasons, I am currently unable to open the original deferential 
revision (https://reviews.llvm.org/D157810).

So for those who are facing the same issue, It had the following review comment 
from @ributzka 

> There is an opportunity for optimization by avoiding the allocation of 
> separate strings for each source location, especially since many source 
> locations will be in the same file. As an example, APISet utilizes a 
> BumpPtrAllocator to allocate and deduplicate strings. It is recommended to 
> consider using the same allocator or a similar concept.

https://github.com/llvm/llvm-project/pull/65891
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to