cor3ntin wrote:

Thanks for working on this.

I wonder if it's maybe too clever? Comparing to 0 is only one of the possible 
fix, I usually try to make sure my types are consistent instead - which is not 
something a fixit could do.

The more annoying thing is that this does not interact well with 
`-Wold-style-cast` and most C++ guidelines. In C++ we would want to use a 
`static_cast` instead.

Either way, the diagnostic changes are a nice improvement


https://github.com/llvm/llvm-project/pull/65684
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to