aaron.ballman edited reviewers, added: pengfei; removed: mibintc. aaron.ballman added a comment.
Changing the reviewers up a bit; the changes generally seem reasonable to me, but I'd appreciate some x86 reviewer viewpoints. ================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:317 + " with attribute 'no_caller_saved_registers'" + " or be compiled with '-mgeneral-regs-only'">, + InGroup<DiagGroup<"excessive-regsave">>; ---------------- Can you add a test case showing that `-mgeneral-regs-only` causes the diagnostic to be silenced? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159068/new/ https://reviews.llvm.org/D159068 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
