ABataev added a comment. In D158778#4622901 <https://reviews.llvm.org/D158778#4622901>, @tra wrote:
> @ABataev > > This patch breaks breaks two tests: > > - > github.com/llvm/llvm-project/blob/main/clang/test/OpenMP/nvptx_unsupported_type_codegen.cpp > - > github.com/llvm/llvm-project/blob/main/clang/test/OpenMP/nvptx_unsupported_type_messages.cpp > > It's not clear what exactly these tests are testing for and I can't tell > whether I should just remove the checks related to `__float128`, or if > there's something else that would need to be done on the OpenMP side. > > AFAICT, OpenMP will pick up `double` format for `__float128` after my patch. > This suggests that we would only have `long double` left as an unsupported > type on GPU-supporting targets, which suggests that I should just remove the > checks related to `__float128` from those tests. > > Am I missing something? Is there anything else that may need to be done on > the OpenMP side? Just checks removal should be fine Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158778/new/ https://reviews.llvm.org/D158778 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
