efriedma added a comment.

If you don't have autoupgrade, that means you can't link IR built with older 
versions of LLVM to IR built with newer versions.  
llvm::UpgradeDataLayoutString is designed to fix this incompatibility.  It's 
probably worth doing here given that it's relatively straightforward.

The issue with the i128 datalayout ugrade isn't the datalayout string itself, 
it's that the datalayout change affects existing code in a non-trivial way.  
That isn't really an issue here: there shouldn't be any existing AArch64 IR 
using address-space 270, so changing its meaning won't have any effect.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158857/new/

https://reviews.llvm.org/D158857

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to