jhuber6 added a comment.
Just a few more nits. I think it's looking fine but I haven't tested it. Anyone
else?
================
Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:406
+ // pass on -mllvm options to the clang
+ for (const opt::Arg *Arg : Args.filtered(OPT_mllvm)) {
----------------
================
Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:415-417
+ if (SaveTemps) {
CmdArgs.push_back("-save-temps");
+ }
----------------
No braces around a single line if.
================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/utils/UtilitiesRTL.h:54
+
+uint16_t getImplicitArgsSize(uint16_t Version) {
+ return Version < ELF::ELFABIVERSION_AMDGPU_HSA_V5
----------------
We return uint16_t here? These are sizes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139730/new/
https://reviews.llvm.org/D139730
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
