ahatanak added inline comments.
================
Comment at: llvm/tools/clang/test/Sema/vecshift.c:56
@@ +55,3 @@
+
+ vc4 = vc4 << vc8; // expected-error {{vector operands do not have the same
number of elements}}
+ vi4 = vi4 << vuc8; // expected-error {{vector operands do not have the same
number of elements}}
----------------
vbyakovlcl wrote:
> ahatanak wrote:
> > I don't think this patch was necessary to have clang print diagnostic
> > "vector operands do not have the same number of elements"? If that's the
> > case, I think it's better to add these lines in a separate commit.
> Do you propose to delete lines with this diagnostic?
Yes, I think you can move them to a separate patch. Doing so will help people
who read the patch understand what problems you are trying to fix with this
patch.
https://reviews.llvm.org/D24467
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
