aaron.ballman added inline comments.
================
Comment at: clang/test/SemaCXX/constexpr-string.cpp:681
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wconstant-conversion"
+namespace GH64876 {
----------------
shafik wrote:
> erichkeane wrote:
> > rather than suppress these, it makes sense to me to just mark them
> > expected-warning.
> It depends on the size of `size_t` whether I get this diagnostic or not.
Given that the point to this test isn't to test constant conversion behavior
but is testing boundary cases where you'll get those diagnostics, I think
suppressing the warnings is fine.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158557/new/
https://reviews.llvm.org/D158557
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
