dmgreen added a comment. Sounds good. Can you make sure you upload with context, it makes the patches easier to read in phabricator: https://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch.
================ Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:6297 [(set (v2f64 V128:$Rd), (OpNode (v2f64 V128:$Rn)))]>; + def f64 : BaseSingleOperandFPData<{0b0100, U, opc}, + FPR64, f64, asm, null_frag>; ---------------- This looks like it is defining a new instruction. Does that already exist somewhere? Probably from somewhere like FRIntNNT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158626/new/ https://reviews.llvm.org/D158626 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits