hazohelet added inline comments.

================
Comment at: libcxx/include/__type_traits/is_constant_evaluated.h:31
+  return false;
+#endif
 }
----------------
Mordante wrote:
> Why is this needed? Does this mean the builtin will fail in C++03 mode?
`__libcpp_is_constant_evaluated` always returns false under C++03 or earlier, 
where constexpr isn't available. This is a fix to run libc++ tests without 
seeing warnings from clang with this patch.
(Live demo: https://godbolt.org/z/oszebM5o5)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155064/new/

https://reviews.llvm.org/D155064

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to