Author: Rashmi Mudduluru Date: 2023-08-15T15:41:56-07:00 New Revision: cf1c64b94d94105f61e308e57eb963b722d22d77
URL: https://github.com/llvm/llvm-project/commit/cf1c64b94d94105f61e308e57eb963b722d22d77 DIFF: https://github.com/llvm/llvm-project/commit/cf1c64b94d94105f61e308e57eb963b722d22d77.diff LOG: [-Wunsafe-buffer-usage] Replace assert that declarations are always found Differential Revision: https://reviews.llvm.org/D157018 Added: Modified: clang/lib/Analysis/UnsafeBufferUsage.cpp clang/test/SemaCXX/warn-unsafe-buffer-usage-debug.cpp Removed: ################################################################################ diff --git a/clang/lib/Analysis/UnsafeBufferUsage.cpp b/clang/lib/Analysis/UnsafeBufferUsage.cpp index 6f9f5f5e7ee7f2..87087686171347 100644 --- a/clang/lib/Analysis/UnsafeBufferUsage.cpp +++ b/clang/lib/Analysis/UnsafeBufferUsage.cpp @@ -888,7 +888,8 @@ class DeclUseTracker { const DeclStmt *lookupDecl(const VarDecl *VD) const { auto It = Defs.find(VD); - assert(It != Defs.end() && "Definition never discovered!"); + if (It == Defs.end()) + return nullptr; return It->second; } }; @@ -2053,7 +2054,10 @@ static FixItList fixVariableWithSpan(const VarDecl *VD, ASTContext &Ctx, UnsafeBufferUsageHandler &Handler) { const DeclStmt *DS = Tracker.lookupDecl(VD); - assert(DS && "Fixing non-local variables not implemented yet!"); + if (!DS) { + DEBUG_NOTE_DECL_FAIL(VD, " : variables declared this way not implemented yet"); + return {}; + } if (!DS->isSingleDecl()) { // FIXME: to support handling multiple `VarDecl`s in a single `DeclStmt` DEBUG_NOTE_DECL_FAIL(VD, " : multiple VarDecls"); diff --git a/clang/test/SemaCXX/warn-unsafe-buffer-usage-debug.cpp b/clang/test/SemaCXX/warn-unsafe-buffer-usage-debug.cpp index 79031cdb7691d3..f0f9a52cc3d0c9 100644 --- a/clang/test/SemaCXX/warn-unsafe-buffer-usage-debug.cpp +++ b/clang/test/SemaCXX/warn-unsafe-buffer-usage-debug.cpp @@ -66,3 +66,15 @@ void implied_unclaimed_var(int *b) { // expected-warning{{'b' is an unsafe poin b++; // expected-note{{used in pointer arithmetic here}} \ // debug-note{{safe buffers debug: failed to produce fixit for 'b' : has an unclaimed use}} } + +int *a = new int[3]; // expected-warning{{'a' is an unsafe pointer used for buffer access}} \ +// debug-note{{safe buffers debug: failed to produce fixit for 'a' : neither local nor a parameter}} +void test_globals() { + a[7] = 4; // expected-note{{used in buffer access here}} +} + +void test_decomp_decl() { + int a[2] = {1, 2}; + auto [x, y] = a; + x = 9; +} _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
