steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed.
I can only vouch for the SttaticAnalyzer portion. Those parts makes sense to me. However, I've seen cases where it doesn't resonate. As a rule of thumb, if we are "copying" only at most 3 pointers, I'd rather still just make a copy instead of by reference. Please check if your recommended changes reflect this. If you decide to take it by reference, prefer taking it also by const. Let me know if you oppose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157129/new/ https://reviews.llvm.org/D157129 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
