MaskRay added a comment. I think `assert((A == B || (A->getOverloadedOperator() == OO_EqualEqual && B->getOverloadedOperator() == OO_EqualEqual)) && ...);` would look better , but the current form is fine as well.
> You will see 2 failures in > llvm/llvm-project/clang/test/CodeGen:available-externally-hidden.cpp.test and > llvm/llvm-project/clang/test/CodeGenCXX:cxx2a-three-way-comparison.cpp.test ( This is the gist and I think it should have been included in the patch summary/git message, so that readers can get the information from the commit message, not just by reading the long discussions on this page. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155809/new/ https://reviews.llvm.org/D155809 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
