4vtomat marked 2 inline comments as done.
4vtomat added inline comments.
================
Comment at: clang/lib/AST/ItaniumMangle.cpp:3267
case CC_PreserveAll:
+ case CC_RISCVVectorCall:
// FIXME: we should be mangling all of the above.
----------------
aaron.ballman wrote:
> Is it possible to use this calling convention on Windows where we'd hit the
> Microsoft name mangler?
Thanks for reviewing. However since RISCV target currently only supports `elf`,
so maybe we will do this in the future!
================
Comment at: clang/test/CodeGen/RISCV/riscv-vector-cc-attr.c:1
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
+// REQUIRES: riscv-registered-target
----------------
aaron.ballman wrote:
> You should also have Sema tests for various things (attribute accepts no
> arguments, only applies to functions, does/doesn't silently convert to cdecl,
> etc). You should also have some tests using the attribute as a type attribute
> instead of a declaration attribute.
>
> You should also have C++ tests for Sema and codegen for things like putting
> the calling convention on a member function or a lambda to ensure those do
> reasonable things with the convention.
Good idea, thanks for your review, I will add some tests for Sema!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154576/new/
https://reviews.llvm.org/D154576
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
