dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land.
FWIW this sounds good to me (though given how wide the patch is, might be worth waiting a few days to a week in case anyone else has thoughts). I only looked at a sample of the test changes - if there's anything much more interesting than adding `not` to any tests, might be worth calling those out in the description/review/etc - and maybe discuss what to do with `not`s that are added but because the test is buggy/mistaken. Them being explicit may confuse future users into thinking they're intentional, rather than pragmatic. Don't really know what to do about that - probably nothing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156363/new/ https://reviews.llvm.org/D156363 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
