[PATCH] D155526: [-Wunsafe-buffer-usage] Fix a fallthrough case in UPCStandalonePointer getFixits

[Rashmi Mudduluru via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG070358ec9235: [-Wunsafe-buffer-usage] Fix a fallthrough case 
in UPCStandalonePointer getFixits (authored by t-rasmud).
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Changed prior to commit:
  https://reviews.llvm.org/D155526?vs=543700&id=544087#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155526/new/

https://reviews.llvm.org/D155526

Files:
  clang/lib/Analysis/UnsafeBufferUsage.cpp
  clang/test/SemaCXX/warn-unsafe-buffer-usage-test-unreachable.cpp


Index: clang/test/SemaCXX/warn-unsafe-buffer-usage-test-unreachable.cpp
===================================================================
--- /dev/null
+++ clang/test/SemaCXX/warn-unsafe-buffer-usage-test-unreachable.cpp
@@ -0,0 +1,8 @@
+// RUN: %clang_cc1 -std=c++20 -Wunsafe-buffer-usage 
-fsafe-buffer-usage-suggestions -verify %s
+
+// expected-no-diagnostics
+
+typedef unsigned __darwin_size_t;
+typedef __darwin_size_t size_t;
+ #define bzero(s, n) __builtin_bzero(s, n)
+void __nosan_bzero(void *dst, size_t sz) { bzero(dst, sz); }
Index: clang/lib/Analysis/UnsafeBufferUsage.cpp
===================================================================
--- clang/lib/Analysis/UnsafeBufferUsage.cpp
+++ clang/lib/Analysis/UnsafeBufferUsage.cpp
@@ -1512,8 +1512,8 @@
                         FixItHint::CreateInsertion(
                             (*EndOfOperand).getLocWithOffset(1), "[0]")}};
     }
+    break;
   }
-    [[fallthrough]];
   case Strategy::Kind::Iterator:
   case Strategy::Kind::Array:
   case Strategy::Kind::Vector:
@@ -1541,8 +1541,9 @@
       if (EndOfOperand)
         return FixItList{{FixItHint::CreateInsertion(
             *EndOfOperand, ".data()")}};
+      // FIXME: Points inside a macro expansion.
+      break;
     }
-      [[fallthrough]];
     case Strategy::Kind::Wontfix:
     case Strategy::Kind::Iterator:
     case Strategy::Kind::Array:



Index: clang/test/SemaCXX/warn-unsafe-buffer-usage-test-unreachable.cpp
===================================================================
--- /dev/null
+++ clang/test/SemaCXX/warn-unsafe-buffer-usage-test-unreachable.cpp
@@ -0,0 +1,8 @@
+// RUN: %clang_cc1 -std=c++20 -Wunsafe-buffer-usage -fsafe-buffer-usage-suggestions -verify %s
+
+// expected-no-diagnostics
+
+typedef unsigned __darwin_size_t;
+typedef __darwin_size_t size_t;
+ #define bzero(s, n) __builtin_bzero(s, n)
+void __nosan_bzero(void *dst, size_t sz) { bzero(dst, sz); }
Index: clang/lib/Analysis/UnsafeBufferUsage.cpp
===================================================================
--- clang/lib/Analysis/UnsafeBufferUsage.cpp
+++ clang/lib/Analysis/UnsafeBufferUsage.cpp
@@ -1512,8 +1512,8 @@
                         FixItHint::CreateInsertion(
                             (*EndOfOperand).getLocWithOffset(1), "[0]")}};
     }
+    break;
   }
-    [[fallthrough]];
   case Strategy::Kind::Iterator:
   case Strategy::Kind::Array:
   case Strategy::Kind::Vector:
@@ -1541,8 +1541,9 @@
       if (EndOfOperand)
         return FixItList{{FixItHint::CreateInsertion(
             *EndOfOperand, ".data()")}};
+      // FIXME: Points inside a macro expansion.
+      break;
     }
-      [[fallthrough]];
     case Strategy::Kind::Wontfix:
     case Strategy::Kind::Iterator:
     case Strategy::Kind::Array:

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits