aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LG! ================ Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:234 + if (!LT || !RT || !T) + return this->bail(BO); ---------------- tbaeder wrote: > aaron.ballman wrote: > > Should we be checking `!T` earlier (it's used within the `Discard` lambda > > with an unprotected dereference)? > Probably, but I changed this again a bit in https://reviews.llvm.org/D148925, > so I'd like to do that change in a later commit. At some point, we need to stop having these interdependencies -- they make reviewing the code *much* harder because the changes are split across so many patches (some of which are in progress, some already accepted but not landed, etc). The new interpreter was in a weird state regarding how little we could test with it before, but we should strive to get to fully isolated changes ASAP (I think we're pretty close). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144164/new/ https://reviews.llvm.org/D144164 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
