sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land.
I don't have a strong opinion here (or solid understanding of dynamic linking!) I suppose the idea is that clangdMain has dependencies from the source files in this directory, and the clangd binary has dependencies from the tweaks that we link in as object files. This seems reasonable but also fragile - I honestly don't see a good workflow to understand exactly which deps are necessary and when this changes other than watching for failure reports on various platforms. (The static build is much simpler in this regard) So I can see an argument (though not really the practical benefit) for minimizing the set of deps now to be more correct, and also an argument for having all targets depend on everything to minimize churn. Up to you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155540/new/ https://reviews.llvm.org/D155540 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
