v.g.vassilev added inline comments.
================
Comment at: clang/unittests/Interpreter/CodeCompletionTest.cpp:71
+ Completer(std::string("void app("), 9);
+ EXPECT_EQ((size_t)0, out.length());
+}
----------------
capfredf wrote:
> @v.g.vassilev The way I fixed this is a bit hacky. Do you have a better idea?
Now I think I understand what you were after. Instead of handling the error in
the constructor we should handle it in the caller. Here is some information how
we could do that:
https://llvm.org/docs/ProgrammersManual.html#fallible-constructors
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154382/new/
https://reviews.llvm.org/D154382
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
