tahonermann added a comment. It is unclear to me why/when we would ever want the substitute drive expansion; the modified tests aren't very elucidating. My naive expectation is that we effectively want to restore the Python 3.7 behavior.
================ Comment at: clang/test/ExtractAPI/relative_include.m:24 +// RUN: %{/t:real}/Frameworks/MyFramework.framework/Headers/MyHeader.h \ +// RUN: %{/t:real}/QuotedHeader.h \ // RUN: -o %t/output.json 2>&1 -verify | FileCheck -allow-empty %s ---------------- I'm curious why this test requires the `%{/t:real}` normalization. Why would it be desirable to expand substitute drives for this test? ================ Comment at: clang/test/Lexer/case-insensitive-include-win.c:8 // RUN: touch %t.dir/foo.h -// RUN: not %clang_cl /FI\\?\%t.dir\FOO.h /WX -fsyntax-only %s 2>&1 | FileCheck %s +// RUN: not %clang_cl /FI\\?\%{t:real}.dir\FOO.h /WX -fsyntax-only %s 2>&1 | FileCheck %s ---------------- I'm curious why this test requires the `%{/t:real}` normalization. Why would it be desirable to expand substitute drives for this test? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154130/new/ https://reviews.llvm.org/D154130 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits