dblaikie added inline comments.
================
Comment at: clang/include/clang/Driver/Options.td:3220
Values<"simple,mangled">, Flags<[CC1Option, NoDriverOption]>;
+def gsrc_hash_EQ : Joined<["-"], "gsrc-hash=">,
+ Group<g_flags_Group>, Flags<[CC1Option, NoDriverOption]>,
----------------
thakis wrote:
> dblaikie wrote:
> > This is a driver flag, yeah? Might be worth documenting/emitting a warning
> > that it's not compatible with DWARF emission? (looks like the DWARF code in
> > LLVM ignores any hash that's not MD5, because DWARF doesn't have a way to
> > encode other hash algorithms currently - though maybe there's some
> > extension space available to add it, I haven't checked/looked)
> belated: this is `Flags<[CC1Option, NoDriverOption]>,` in the line below, so
> I think this isn't a driver flag. (It's what the CLFlags added below expand
> to – those are driver flags, but only for clang-cl.)
Oh, I see - I think I was confused by the driver code referencing
`gsrc_hash_EQ` - but that's because the `/ZH` are implemented as aliases for
`gsrc_hash_EQ`.
I guess then maybe my comment applies to `/ZH` - if someone asks for DWARF and
uses that flag? But maybe not worth it...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134544/new/
https://reviews.llvm.org/D134544
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
