Amir marked 7 inline comments as done. Amir added inline comments.
================ Comment at: clang/utils/perf-training/perf-helper.py:75 + parser.add_argument( + "--lbr", required=False, action="store_true", help="Use perf with branch stacks" + ) ---------------- phosek wrote: > This could be omitted. I think it's best to keep it as optional argument, not positional. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
