shafik added inline comments.
================
Comment at: clang/lib/AST/ExprConstant.cpp:16408
+ Char) ||
+ !Char.isInt())
+ return false;
----------------
Why are we specifically checking `!isInt()` what `Kind` do we expect?
================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16920
+ AddMethodCandidate(DeclAccessPair::make(D, D->getAccess()), ObjectType,
+ ObjectClassification, /*Args*/ {}, Candidates);
+ }
----------------
================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16933
+ :
diag::err_static_assert_invalid_data)),
+ *this, OCD_AllCandidates, /*Args*/ {});
+ }
----------------
================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16952
+ if (!SizeMember)
+ FindMember("size", SizeNotFound, /*Diag*/ true);
+ if (!DataMember)
----------------
================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16954
+ if (!DataMember)
+ FindMember("data", DataNotFound, /*Diag*/ true);
+ return false;
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154290/new/
https://reviews.llvm.org/D154290
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
