aaron.ballman added a comment. In D155078#4494167 <https://reviews.llvm.org/D155078#4494167>, @ldionne wrote:
> In D155078#4493995 <https://reviews.llvm.org/D155078#4493995>, @aaron.ballman > wrote: > >> In D155078#4493468 <https://reviews.llvm.org/D155078#4493468>, @ldionne >> wrote: >> >>> Ok, this is ready to go. More context around this change: >>> >>> I created a clang-specific CI pipeline >>> (https://buildkite.com/llvm-project/clang-ci) and Clang CI jobs will now >>> trigger inside that pipeline instead of inside the libc++ pipeline >>> (https://buildkite.com/llvm-project/libcxx-ci). The problem this solves is >>> that 90% of the jobs of the libc++ CI pipelines are otherwise Clang jobs, >>> which makes it nearly impossible for libc++ to figure out information about >>> the jobs we're actually running. >>> >>> - For now, this does not have any impact on the fact that Clang CI is still >>> utilizing libc++ resources (although this is next on my list of things to >>> address). >>> - This doesn't have any impact on whether we'll eventually want to move to >>> Github Actions or some other CI system. This simply fixes the current >>> system before the LLVM 17 release. In particular, I would like to avoid >>> bikeshedding the location of the `generate-buildkite-pipeline` scripts >>> under `.ci` -- it doesn't matter, I just wanted a neutral >>> (non-libcxx-specific) location and that can be changed later once CI has >>> stabilized. >> >> Please excuse my ignorance, but does this change precommit CI test coverage >> when reviews are created/updated? e.g., if a review goes up with changes >> only to Clang, will the review still get a libc++ test run to ensure the >> Clang changes don't break libc++? > > It actually fixes it. Previously, if both libc++ and Clang were modified in a > review, only the libc++ CI was triggered. After this patch: > > - If Clang is modified, the Clang pre-commit CI is triggered (which includes > running the libc++ test suite w/ just-built clang in C++03, C++20 and Modules > IIRC) > - If Libc++ is modified, the libc++ pre-commit CI is triggered (which > includes the 60ish jobs we have) > - If both are modified, both are triggered. Thank you, this sounds great to me then! LGTM. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155078/new/ https://reviews.llvm.org/D155078 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
